Skip to content

Bookings: Filter bookings for tabs #16190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2025
Merged

Bookings: Filter bookings for tabs #16190

merged 4 commits into from
Oct 3, 2025

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Oct 1, 2025 •
edited
Loading

Part of WOOMOB-1392

Description

This PR updates the Networking and Yosemite layers to support filter bookings by dates to support different tabs of bookings. The integration of the new fields will be handled in a subsequent PR.

Also updated the logic for clearing cache to avoid clearing cache when switch tabs. I'll update the BookingListViewModel to support clearing cache only upon pulling to refresh later.

Testing steps

Since the new fields haven't been used yet, just CI passing is sufficient.

Testing information

Added unit tests for updates in BookingsRemote and BookingStore.

Screenshots

N/A

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.4 milestone Oct 1, 2025
@itsmeichigo itsmeichigo added the type: task An internally driven task. label Oct 1, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 1, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16190-2d57e62
Version23.3
Bundle IDcom.automattic.alpha.woocommerce
Commit2d57e62
Installation URL7lgum3qpftsh0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review October 2, 2025 10:27
Base automatically changed from woomob-1392-booking-list-tabs to trunk October 2, 2025 10:39
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 2, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.4. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

RafaelKayumov
RafaelKayumov approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsmeichigo itsmeichigo merged commit 8c116c4 into trunk Oct 3, 2025
17 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1392-filter-bookings-for-tabs branch October 3, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelKayumov RafaelKayumov RafaelKayumov approved these changes

Assignees

No one assigned

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.4

Development

Successfully merging this pull request may close these issues.

5 participants

@itsmeichigo @wpmobilebot @dangermattic @RafaelKayumov